overblog / GraphQLBundle

This bundle provides tools to build a complete GraphQL API server in your Symfony App.
MIT License
783 stars 221 forks source link

Make the `ConnectionBuilder` class a generic type #1042

Closed ste93cry closed 2 years ago

ste93cry commented 2 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
License MIT

By making the ConnectionBuilder class a generic type, the static analysis tools will understand that the outputted ConnectionInterface contains a list of nodes of the expected type, augmenting the IDE completion and ensuring correctness of the code upstream. I wasn't sure about the target branch to submit the change to, so if I have to change it just ask and I will do it.