search

overblog / GraphQLBundle

This bundle provides tools to build a complete GraphQL API server in your Symfony App.
MIT License
783 stars 221 forks source link

0.15.2 breaks with PHP8.2 and the latest version of webonyx/graphql-php #1106

Closed pascalwoerde closed 1 year ago

pascalwoerde commented 1 year ago
Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Version/Branch 0.15.2

The latest release 0.15.2 is published as fix, but it is a breaking change. Since it results in a downgrade of webonyx/graphql-php when 15 of later was already used. For PHP8.2 this will result in deprecation warnings and failing tests.

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/webonyx/graphql-php/src/Validator/Rules/ValuesOfCorrectType.php on line 182

For now I use a fixed version 0.15.1 so that everything still works correctly. What is the reason that a downgrade is required, what does this fix?

"overblog/graphql-bundle": "^0.15,!=0.15.2"

pascalwoerde commented 1 year ago

Note that this is already fixed in the master branch, but the latest release (tag) is behind. So cannot provide a PR so solve this issue, please publish a new tag!

Vincz commented 1 year ago

Fixed in latest master. We should publish a new proper version soon.

aviator-ua commented 1 year ago

@Vincz Is it possible to fix this issue in the 0.15 branch? From my side, it takes some time to update Symfony packages in my project to update to switch to latest 1.0

There is a small PR for this https://github.com/overblog/GraphQLBundle/pull/1126