overblog / GraphQLBundle

This bundle provides tools to build a complete GraphQL API server in your Symfony App.
MIT License
783 stars 221 forks source link

fix: Fix the memory leak #1119

Open theofidry opened 1 year ago

theofidry commented 1 year ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? could not check
Documented? no
Fixed tickets #721
License MIT

Follow up of my comment.

I cannot investigate further, but my guess is that exceptions are not cheap objects. When creating an exception you also capture the context and stack trace which means that even if the extension is unsued:

Vincz commented 1 year ago

Hi @theofidry! Can you check the tests please? Don't have time to dig into this atm but it seems to break the tests suite: https://github.com/overblog/GraphQLBundle/pull/1119/checks

Thanks!

Vincz commented 1 year ago

Hi @theofidry! Any update on this topic? Thanks!

theofidry commented 1 year ago

Sorry will try to come back to this in a near future