search

overblog / GraphQLBundle

This bundle provides tools to build a complete GraphQL API server in your Symfony App.
MIT License
788 stars 222 forks source link

Fix argument transformer for typed properties without default value #1143

Closed deeky666 closed 1 year ago

deeky666 commented 1 year ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets #1073
License MIT

Fixes https://github.com/overblog/GraphQLBundle/pull/1073#issuecomment-1759508677

The change did not consider typed properties without default value. This actually breaks existing application when upgrading to v1.0.

Vincz commented 1 year ago

Hi @deeky666. Thanks for your contribution. Do you mind adding this little "," to fix the Coding standard https://github.com/overblog/GraphQLBundle/actions/runs/6772086141/job/18404788511?pr=1143#step:5:84

I'll merge after. Thanks!

deeky666 commented 1 year ago

@Vincz sorry I didn't see that in the PR. Fixed it :)

Vincz commented 1 year ago

Thank you @deeky666 for the contribution!