search

overblog / dataloader-bundle

This bundle allows to easy use DataLoaderPHP in your Symfony project through configuration.
MIT License
46 stars 14 forks source link

Support FQCN services names #18

Closed Liinkiing closed 6 years ago

Liinkiing commented 6 years ago

Related issue

14

I've seen that in the issue maybe you wanted to make something more advanced, using the compiler pass because the regex will not be sufficient anymore. But with the regex, it would actually fail if you do not specify a valid service name. Maybe you really don't want at the moment to use regex, but I've wanted to submit this PR anyway to see if you will be okay to use that regex in the meantime. I don't know enough how works the compiler pass so I could not try to make something more advanced, but I'll totally understand if you don't want to support FQCN services names with a simple regex ! 👍

mcg-web commented 6 years ago

Hi @Liinkiing thank you for contributing. This look good to me for the meantime but can you add a test to cover this case please?

Liinkiing commented 6 years ago

@mcg-web Done!

mcg-web commented 6 years ago

Thank you @Liinkiing