Move CS to Github Actions

overblog / dataloader-php

DataLoaderPhp is a generic utility to be used as part of your application's data fetching layer to provide a simplified and consistent API over various remote data sources such as databases or web services via batching and caching.

MIT License

199 stars 21 forks source link

Move CS to Github Actions #52

Closed simPod closed 3 years ago

simPod commented 3 years ago

@mcg-web I've run this without https://github.com/overblog/dataloader-php/commit/8a78a51235d9b5902e44fd21b40439592d4ebb1f and expected some failure but the check gives no error. I don't use cs-fixer so maybe if you could confirm this works as expected?

mcg-web commented 3 years ago

Yes @simPod, this should failed since header is required by config.

simPod commented 3 years ago

@mcg-web travis does not fail as well. It fails locally. Not sure how that tool works TBH 🤷🏾

mcg-web commented 3 years ago

seem like I'm missing something, maybe the difference come from travis phpcs cache. Lets try with a next change, can you replace that by private static $instances = array(); please?

simPod commented 3 years ago

now GA failed so I guess it's overall working and we can keep only the first commit?

mcg-web commented 3 years ago

yes we can keep only the first commit, can you rewrite the history please, so we can merge this?

simPod commented 3 years ago

sure done