overblog / dataloader-php

DataLoaderPhp is a generic utility to be used as part of your application's data fetching layer to provide a simplified and consistent API over various remote data sources such as databases or web services via batching and caching.

MIT License

199 stars 21 forks source link

chore(deps): require php 8.1 #62

Closed simPod closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #62 (c0f3b5d) into master (333f5eb) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff             @@
##             master      #62    +/-   ##
==========================================
  Coverage     57.53%   57.53%            
- Complexity        0      128   +128     
==========================================
  Files             7        7            
  Lines           332      332            
==========================================
  Hits            191      191            
  Misses          141      141

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Spriz commented 1 year ago

Curious question - why bump PHP requirements if not using any 8.1 specific features? :thinking:

simPod commented 1 year ago

Cannot use 8.1 specific features without the bump.

ruudk commented 1 year ago

Can be closed, handled in https://github.com/overblog/dataloader-php/pull/67