overbound / SonicTimeTwisted

Source Code for a Sonic Fan Game Made in Game Maker Studio
https://overboundstudio.com/
GNU General Public License v3.0
55 stars 16 forks source link

Some visual effects not working properly on Android #11

Closed AlexKhayrullin closed 6 years ago

AlexKhayrullin commented 6 years ago

This is a big one.

Some special effects that make use of either shaders or some draw modes (didn't look into it yet) don't work properly on Android, and might not work on other platforms the game might be ported to. So far, I've seen two clear cases:

So, to resolve this, this is what needs to be done:

overbound commented 6 years ago

This may be a bug in Game Maker Studio. Via: Here

If all else fails I will replace the effects static animations. But I will wait to resolve this issue until the port is nearly complete.

AlexKhayrullin commented 6 years ago

Yes, I absolutely agree, it needs to be done at the very end of the development of the port, so there's no emergency here. Just something to keep in mind.

Also, I'd say that these newer, simpler animations absolutely should not replace those that are already in place. My rationale is this: if the default effects work as expected on a platform the game is being ported to, then use them; if they don't, use simpler animations, maybe implement a script "are_animations_supported()" that returns true or false depending on the platform, and work from there? I would absolutely hate to replace the very good looking effects that are already in place with simpler ones on platforms that don't need this switch...

overbound commented 6 years ago

Agreed we can check the OS before determining which one to use.

AlexKhayrullin commented 6 years ago

As I know nothing about shaders, I decided to do much simpler effects. There are three times where the Time Travel shader appears:

I know that these aren't perfect alternatives, but they look... serviceable.

I can confirm that the Time Travel shader is the only visual effect not supported on Android.

If someone wants to remake these animations into something better, feel free to open a new issue.