Improvements to surfaces, time travel code, and an attempt to fix YYC.

overbound / SonicTimeTwisted

Source Code for a Sonic Fan Game Made in Game Maker Studio

https://overboundstudio.com/

GNU General Public License v3.0

60 stars 16 forks source link

Improvements to surfaces, time travel code, and an attempt to fix YYC. #69

Closed nkrapivin closed 4 years ago

nkrapivin commented 4 years ago

What's new:

set windows exe version to 1.1.0
added vsync menu option to video settings
some objects called surface_reset_target while no surface has been set, GMS1 doesn't care, but GMS2 throws an error "Reset target when no target was set", then "UNBALANCED SURFACE STACK", and then it quits.
also YoYo doesn't recommend creating surfaces in the Create event, rather you should only create a surface right when you need it. (https://docs.yoyogames.com/source/dadiospice/002_reference/surfaces/index.html docs actually say that you should create them in the Draw Event but that's not true)
enabled "Create textures on Demand" in Windows config because the Windows Runner preloads all texture pages in memory, and draw_texture_flush does nothing (https://docs.yoyogames.com/source/dadiospice/002_reference/drawing/draw_texture_flush.html), but if you tick that checkbox it will only load texture pages when needed like on every other platform. (This is on by default in GMS2 by the way)
time travel scripts never call shader_set if tts_ok is false, which will prevent the game from crashing.

TL;DR: add vsync to menu, fix errors that happen when importing to GMS2.

nkrapivin commented 4 years ago

Since Alex merged #67 a little bit too early (my bad), I'll finish off the translation PR here as a separate commit.

VectorSatyr commented 4 years ago

@AlexKhayrullin @nkrapivin Please determine if the switch to "Create Textures on Demands" creates a significant enough improvement for deployment to Android.

nkrapivin commented 4 years ago

There appears to be irrelevant changes to the SttAndroidGamepad extension. Please investigate.

They are relevant, I unticked all checkboxes except Android and Android (YYC) which resolved "Bad Image" window popping up when running the game. (Runner tried to load .ext file as a dll)

nkrapivin commented 4 years ago

Please determine if the switch to "Create Textures on Demands" creates a significant enough improvement for deployment to Android.

It is enabled by default on every other platform except Windows, and you can't disable this afaik.

nkrapivin commented 4 years ago

There appears to be irrelevant changes to the SttAndroidGamepad extension. Please investigate.

They are relevant, I unticked all checkboxes except Android and Android (YYC) which resolved "Bad Image" window popping up when running the game. (Runner tried to load .ext file as a dll)

VectorSatyr commented 4 years ago

* There appears to be irrelevant changes to the SttAndroidGamepad extension. Please investigate.
They are relevant, I unticked all checkboxes except Android and Android (YYC) which resolved "Bad Image" window popping up when running the game. (Runner tried to load .ext file as a dll)

Then it belongs in a separate commit. This is for "Improvements to graphics stuff", not bug fixes to gamepads. Mixing concerns makes changes harder to track. People looking at the commit history won't immediately know that this also so happens to fix a crash on Android platforms, because they wouldn't think it had anything to do with a graphical update.

* Please determine if the switch to "Create Textures on Demands" creates a significant enough improvement for deployment to Android.
It is enabled by default on every other platform except Windows, and you can't disable this afaik.

That, in and of itself, is not evidence of a performance improvement. The truth is, this option was considered before, but was ultimately deemed unnecessary, so there needs to be some tangible benchmarks if we are going to reconsider.

nkrapivin commented 4 years ago

Then it belongs in a separate commit. This is for "Improvements to graphics stuff", not bug fixes to gamepads. Mixing concerns makes changes harder to track. People looking at the commit history won't immediately know that this also so happens to fix a crash on Android platforms, because they wouldn't think it had anything to do with a graphical update.

It's fixing seven error windows on non-Android platforms, not an Android crash, because the engine is trying to load .ext file as a .dll.

Also do I make a separate commit then?

VectorSatyr commented 4 years ago

Then it belongs in a separate commit. This is for "Improvements to graphics stuff", not bug fixes to gamepads. Mixing concerns makes changes harder to track. People looking at the commit history won't immediately know that this also so happens to fix a crash on Android platforms, because they wouldn't think it had anything to do with a graphical update.

It's fixing seven error windows on non-Android platforms, not an Android crash, because the engine is trying to load .ext file as a .dll.

Also do I make a separate commit then?

Yes, please.

nkrapivin commented 4 years ago

As a separate PR or revert this commit and force-push new ones?

VectorSatyr commented 4 years ago

Can you not add the additional commit to the pull request?

nkrapivin commented 4 years ago

That duplicates the changes of the previous one?

nkrapivin commented 4 years ago

Okay I've split this PR into multiple commits.

nkrapivin commented 4 years ago

I'll finish off translation stuff in a separate PR... when I'll finally get at least one Russian font that I can play with...