overbound / SonicTimeTwisted

Source Code for a Sonic Fan Game Made in Game Maker Studio
https://overboundstudio.com/
GNU General Public License v3.0
58 stars 16 forks source link

Some elements that used to flash don't anymore #71

Closed AlexKhayrullin closed 3 years ago

AlexKhayrullin commented 4 years ago

Probably as a consequence of me adding and then removing a 30FPS mode (which I thought could improve performances on older Android phones) , some elements that used to flash no longer do.

What I've seen so far: "3 2 1 GO" after the race against Metal Sonic starts; appearing blocks in AAZ Past, maybe the lights in the background of AAZ future, I'm not sure.

nkrapivin commented 4 years ago

"3 2 1 GO" doesn't flash because User Event 15 toggles flashing... and you've removed the with (all) event_user(15); line when removing 30 FPS mode. :p

Maybe some other objects rely on it idk the project file is huge and GMS1 IDE is slow.

AlexKhayrullin commented 4 years ago

Yup, that's exactly what happened ^^'

I thought I'd restored all of them, but apparently not...

AlexKhayrullin commented 3 years ago

After combing through the project (not manually though, but by searching the string <event eventtype="7" enumb="25"> in the entire project with Notepad++) , it appears that the following objects are affected. Some of these I've seen, some I haven't, or maybe haven't paid attention:

I did a first pass, removing the events and putting the old code back from master, but I might have missed some. I'll do a second pass later, using Meld to compare these objects.

AlexKhayrullin commented 3 years ago

Second pass done.

Will now test all these objects to make sure they flash in-game.

AlexKhayrullin commented 3 years ago

Fun fact: objAALampLight has never been flashing due to a bug. Once fixed, the coded flashing that made the alpha go between 1 and 0.5 was too distracting, so I dialed it back to 0.75-0.5

AlexKhayrullin commented 3 years ago

Tested all those I could, I have a feeling like objGalanikEyeShine isn't actually used. All other objects are fixed and confirmed to be working.