AlexKhayrullin
commented
3 years ago Hi and thanks for the PR :)
A couple of comments:
- Usually, you don't close an issue until after the PR is accepted ;)
- Thanks for the translation!
- It apparently wasn't clear enough in the original English strings, but not calling Joy-Cons by their name in-game was a conscious choice on my part, I wanted to keep it generic... just in case. You know how ridiculous Nintendo can be, I'd rather steer away from clearly naming anything made by them (the one time "Joy-Con" appears in the menu as I've coded it is when the name is provided by the Joy-Con itself), and the irony of it being in the context of a fangame is not lost on me. Also, I get what you are trying to do with the three Joy-Con pictures, unfortunately that's not exactly compatible with the Android library: it can't tell them apart until both of them are connected, when one of them is connected it just knows there's one of the two, it does not care which one of the two it is.
- With the sheer amount of updated graphics, I don't think I have a moral right to approve this on my own. I'll forward this to the rest of the team.
- Can you please tell me who to credit for all these graphics and how (like, what format? full name? just the username? both?), I guess you are behind most of it, and the Golem and the Firefly were reshaded by Bennascar.
romulok77
nkrapivin
intname is the language code so should be
change of some sprites (including boss gollen and FireFly #89 and something of #93 ) and few animations along with the most recent Brazilian Portuguese translation.
And a suggestion, when switching to dual mode, a switch control appears indicating the player about the first and second device. but I only drew anything so far. this would be below the line: press a button of first or second device, https://ibb.co/6yqNRp6
my god I hope everything is here