search

overcache / NeoSolarized

NeoSolarized: A fixed solarized colorscheme for better truecolor support.
MIT License
517 stars 99 forks source link

Highlight background of vertical split bar #8

Closed HiPhish closed 7 years ago

HiPhish commented 7 years ago

Both Solarized and Flattened highlight the vertical split bar. If the user has set whitespace as the 'fillchars' the border would be invisible.

I don't know why the background of your scheme is empty, was that a deliberate design decision? I don't like the vertical dashes as a separator character, it looks too noisy to me and I prefer a solid coloured line instead.

overcache commented 7 years ago

Thanks for your work! And yes, it's a deliberate decision. I think it's more harmonious with a transparent bg for vertsplit bar. But I added a new option for someone like you just now. If you do like a vertsplitbar with base00 bg, update to latest version and add this line to your dotfile: let g:neosolarized_vertSplitBgTrans = 0

HiPhish commented 7 years ago

@icymind How about base02 as the background colour? That's the same background as for the status bar and the tab bar, that way all separators have the same colour. screen shot 2016-12-19 at 18 53 49

HiPhish commented 7 years ago

Oh and BTW, I would take that option out. The same effect can be achieved by setting the unicode character U+2588 (FULL BLOCK █) for the vert key in the fillchars option. You option just bloats the code. I just made the PR because I thought it was an oversight, I didn't know it was a deliberate choice.