overdodactyl / Mozilla-Dark

A dark theme for bugzilla
MIT License
10 stars 2 forks source link

Using colour variables from ShadowFox #3

Open CaptaPraelium opened 6 years ago

CaptaPraelium commented 6 years ago

Is there a practical way to do this?

Great work as usual BTW :)

overdodactyl commented 6 years ago

Thanks!

And what is it exactly you're hoping to be able to do? Are you wanting just to be able to access the variables defined in ShadowFox, or wanting the colors in Mozilla-Dark to be the same as those in ShadowFox? i.e. the set of --grey-10 --> --grey-90, instead of the blacks and greys currently used?

overdodactyl commented 6 years ago

@CaptaPraelium,

What do you think of a version with a color scheme more like this:

bugzilla

It's a little more ShadowFox-y with variables at the top

overdodactyl commented 6 years ago

Here's a few more examples of what I'm thinking of switching to:

screen shot 2018-02-02 at 7 44 50 pm

screen shot 2018-02-02 at 7 42 31 pm

Edit: Here's a sample SuMo page as well:

screen shot 2018-02-03 at 12 00 59 am

CaptaPraelium commented 6 years ago

I think it looks good.... A little too colourful for my tastes, and the green doesn't match with the windoze blue theme... But that's subjective. Objectively, I think it looks great! I guess this is a great example of why I made this thread :)

overdodactyl commented 6 years ago

A little too colourful for my tastes

I've cut back on the colors a little bit since I posted the screenshots (both the number of links that are colored and removed the outlines). Is that where you were thinking or would you prefer to see the header a dark color as opposed to the accent color?

green doesn't match with the windoze blue theme

That's fair. I've been debating what to do with the primary color. Might be best just to make it the default used by ShadowFox. I've used the same variable names, but in the case above, they had different values so they override ShadowFox's.

If one was to have ShadowFox installed, and delete the variables in this theme, it would simply fallback to the colors set by ShadowFox.

CaptaPraelium commented 6 years ago

That sounds great the way you have the variables working!

Regarding colour schemes, if I were you, I wouldn't pay toooo much attention to what capta wants ;)

By this I mean... I think the green header actually looks really stylish. I kinda think you should keep it. But for my particular use-case, I want things as dark as possible without being too high-contrast. I use my PC in a very darkened area, often late at night, and I have eyes that are sensitive to overly high contrast... I think that if there is a scale of "Needs a dark theme 0-10', I am an 11. So, I personally would sacrifice the 'form' of the the coloured header, for the 'function' of keeping it grey... That being said, I believe that form is a function in itself. (and that's why I like the blue because it matches with microsoft's choice of colour, even though IMO the green functions better) Beauty is important! So, you should do what you feel looks beautiful and express your own creativity :)

overdodactyl commented 6 years ago

Regarding colour schemes, if I were you, I wouldn't pay toooo much attention to what capta wants

I don't know about that, you've been pretty helpful with styling choices in ShadowFox! And beyond that, I'm not sure I always have the best stylistic opinions, so it's always good to hear other people's haha.

As for the header color, maybe a good compromise would be to keep it as is by default, but create a new variable for the header. It would initially be set to something like:

--header-color: var(--primary-accent-color);

but then if anyone wanted to change it, all that would have to be done is alter it to something like

--header-color: var(--grey-90);

I am kind of preferring this look to what Mozilla-Dark currently is. It has more simplicity and isn't quite so busy...it also goes with the FF theme better.

CaptaPraelium commented 6 years ago

Hey that's a great idea! Best of both worlds :)

overdodactyl commented 6 years ago

I think I'm getting fairly close to getting this version caught up the other one (Bugzilla should be done, SuMo and developer are almost there)...would you want to give it a test at some point before I send it off to userstyles.org?

CaptaPraelium commented 6 years ago

Sure thing man anything you need!

overdodactyl commented 6 years ago

Awesome, thanks! I'll ping ya here once I've uploaded a version to GitHub :)