Email folders aren't displayed

overdodactyl / ShadowBird

A universal dark theme for Thunderbird

MIT License

112 stars 7 forks source link

Email folders aren't displayed #14

Open ajvsol opened 5 years ago

ajvsol commented 5 years ago

See

Using Thunderbird 60.4.0

overdodactyl commented 5 years ago

Hi @ajvsol -

It appears this is a Thunderbird bug, not a ShadowBird one.

It isn't that the text is black, it just isn't displaying at all. Here it is without ShadowBird:

ajvsol commented 5 years ago

I restored my Thunderbird to pre-ShadowBird state now and the text displays fine for me on 60.4.0:

When I tried to install ShadowBird again it makes the text not display like my initial screenshot.

loopy750 commented 5 years ago

Re the first screenshot, that's kinda what it looks like on Windows without the Windows fixes. I'm guessing that's on Linux? If that's that case the Windows fixes could also be applied to Linux and may or may not work.. I don't have Linux to test it on so I'm not sure, plus there are so many flavours of Linux that results could be unpredictable/a lot of work.

ajvsol commented 5 years ago

Yes probably should have mentioned, it's on Linux.

If you want to test Linux I'd recommend booting it from a USB, it's pretty quick to setup. Also Linux users generally don't mind if there's bugs between different flavours (since it can be fixed by themselves), as long as you support one popular flavour like Ubuntu.

loopy750 commented 5 years ago

Unfortunately I can't find any rules for userchrome.css to detect Linux (or macOS), only various Windows versions and themes, therefore meaning any changes that affect Linux will also affect macOS, and most likely in a negative fashion. Any ShadowBird theme releases for Linux would probably need to be separate to the current version that supports macOS & Windows.

The good news however is the changes for Windows also worked fine for Ubuntu.

So what you could do is find these lines in userchrome.css:

@media screen and (-moz-windows-theme),
screen and (-moz-windows-classic),
screen and (-moz-windows-default-theme),
screen and (-moz-os-version:windows-win7),
screen and (-moz-os-version:windows-win8),
screen and (-moz-os-version:windows-win10) {

and replace with something like

@media screen {

That will of course mess up the macOS styling, but will work fine on Windows and Linux.

Brocklobsta commented 5 years ago

Hey I noticed there are some peculiar column icons that repeat in the first screenshot. What are these? How could I get rid of them?

I am on Ubuntu 18.04 and noticed the added column space when installing shadowbird.

ajvsol commented 5 years ago

@loopy750 apologies for forgetting to reply to this issue btw, your last comment did fix the issue for me :)

@Brocklobsta I don't get that visual discrepancy now, it just looks like the normal Thunderbird columns except in dark theme.

morphiak commented 5 years ago

Confirming the '@media screen {' hack works perfectly for Debian 9 / KDE. Thanks for the nice new look :)

0DayByte commented 5 years ago

On Debian unstable / 10, Thunderbird version 60.8.0, and loopy750 fix worked, thanks