Menus have compact design.

xAphex commented 6 years ago

i found this theme from Reddit, and i freaking love it, the only problem i found with it is that the menus (all of them) have compact design, they all seems to be squished together.

Example:

Help Menu: Before | After

Context Menu: Before | After

Is there something i could change in the CSS files to fix this?

Thank you for creating this awesome theme +1

overdodactyl commented 6 years ago

Hi @xAphex, I'm glad you're enjoying the project!

Funny enough, I was just talking to another fellow Redditor about this. It appears to be a Windows specific problem (and I unfortunately don't have Windows to test on).

Starting on line 61 of dark_context_menus.css, you should see this:

/* Increase height between menu items */
menupopup menu, menuitem {
      padding-top: .5px !important;
}

If you're using the combined userChrome.css file in the main portion of the repo, this appears near line 257.

Try changing that to

menupopup menu,  menuitem {
      padding-top: 5px !important;
      padding-bottom: 5px !important;
}

and let me know if that fixes things.

overdodactyl commented 6 years ago

Should be fixed - will reopen if not.

xAphex commented 6 years ago

yes it fixed it, thank you.

overdodactyl commented 6 years ago

No problem - that's now included in the main repo (only applies to windows users), so if you update you won't have to worry about it.

CaptaPraelium commented 6 years ago

I thought it was in my head....but I liked it so I didn't say anything. Maybe this could be optional in future?

overdodactyl commented 6 years ago

@CaptaPraelium, is it back to looking the "compact" way?

I think I changed it back in ed0b92403373fe984 because the approach I took didn't actually work as I expected

lopardo commented 6 years ago

I get compact menus right now (updated with git) on Manjaro Linux and Windows (both using dark themes/visual styles).

overdodactyl commented 6 years ago

Hi @lopardo, for Windows check out issue #60. If it's a problem for Linux as well I'll try and work on getting a fix included for that

CaptaPraelium commented 6 years ago

I just fixed this by accident. I wish I had the compact menus again! LOL

overdodactyl commented 6 years ago

I can put a different compact version of userChrome in the repo if you would like.

Other option would be to add something like this to the end of your file:

/* Increase height between menu items */
menupopup menu, menuitem {
      padding-top: .5px !important;
      padding-bottom: .5px !important;
}

CaptaPraelium commented 6 years ago

I think it's something I should do to my own chrome, since it's just a user preference of mine...but thankyou for the offer - and for the code! :)

CaptaPraelium commented 6 years ago

Hey, here's a thought though... Each time I update, I edit the css file and add a snippet that looks like this: @import url(./CaptaChromeTweaks.css); I wonder if it would be possible, to add an @import line, at the top and bottom of each of the user*.css files, that way individuals could just leave their mods in place and replace your files without any changes?

overdodactyl commented 6 years ago

@imports only work if they are at the top of the file unfortunately. Since your tweak would be overriding one in userChrome.css it'll have to come after it.

What I think you could do, however, is kinda what's outlined here in the wiki.

i.e. inside your chrome folder, create a ShadowFox directory. This will contain whatever you are using from this repo (likely, userChrome.css and userContent.css it sounds like).

Then, in your chrome directory, you can have a different userChrome.css and userContent.css.

At the top of those lines, you'll have either

@import "ShadowFox/userContent.css";

or

@import "ShadowFox/userChrome.css";

After that, you can append any of your own tweaks, overrides, @import statements etc.

This way, the ShadowFox stuff get's imported, but any of your own things come after it and go into effect.

CaptaPraelium commented 6 years ago

Ahh excellent. I'm going to do this for sure. I feel like this would be a good tip for the installation documents!

overdodactyl commented 6 years ago

I do have it in wiki at that linked position, but I may want to make it a little more prominent and not so specific for that use case.

Unfortunately, it goes back to that problem we discussed long ago where this won't work for everyone because apparently @import statements are broken for some Linux users

overdodactyl / ShadowFox