overdodactyl / ShadowFox

A universal dark theme for Firefox
https://overdodactyl.github.io/ShadowFox/
MIT License
1.32k stars 58 forks source link

New Tab page improvements #256

Closed Sotilrac closed 3 years ago

Sotilrac commented 5 years ago

I understand this comes out of the blue, and you'll think I'm very nitpicky.

I started using Shadowfox today and I love it, but I felt compelled to do some changes to the new tab page. I hope you can include them in your next version.

This is how the the new tab page looks:

Screenshot_20190317_193408

Screenshot_20190317_193439

I generated the userContent_no_addons.css but could not successfully run the gulp minify_final. See the output below:

$ /home/carlos/dev/osc/ShadowFox/node_modules/.bin/gulp all
[19:05:53] Using gulpfile ~/dev/osc/ShadowFox/gulpfile.js
[19:05:53] Starting 'all'...
[19:05:53] Starting 'userChrome'...
[19:05:53] Starting 'userContent'...
[19:05:53] Starting '<anonymous>'...
[19:05:53] Starting 'userContent_no_addons'...
[19:05:53] Starting '<anonymous>'...
[19:05:54] Finished '<anonymous>' after 299 ms
[19:05:54] Finished 'userContent_no_addons' after 318 ms
[19:05:54] '<anonymous>' errored after 319 ms
[19:05:54] Error in plugin "gulp-concat-css"
Message:
    /home/carlos/dev/osc/ShadowFox/css/userContent-files/webextension-tweaks/dark_mode.css:4:3: missing '}'
Details:
    reason: missing '}'
    filename: /home/carlos/dev/osc/ShadowFox/css/userContent-files/webextension-tweaks/dark_mode.css
    line: 4
    column: 3
    source: .comment {
    color: var(--in-content-link-color)!important
  }
  .title {
    background-color: var(--in-content-category-header-background)!important
  }
  .highlight {
    background-color: var(--in-content-box-border-color)!important
  }
}

    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

[19:05:54] 'userContent' errored after 328 ms
[19:05:54] 'all' errored after 329 ms
[19:05:54] The following tasks did not complete: userChrome
[19:05:54] Did you forget to signal async completion?