search

overdodactyl / ShadowFox

A universal dark theme for Firefox
https://overdodactyl.github.io/ShadowFox/
MIT License
1.32k stars 58 forks source link

Firefox 69 incompatibility, easy to solve by two additional settings #285

Open dmilith opened 5 years ago

dmilith commented 5 years ago

ShadowFox could set these values under about:config automatically:

  1. toolkit.legacyUserProfileCustomizations.stylesheets => true
  2. browser.in-content.dark-mode => true

Without these two ShadowFox will have no effect in Firefox 69+

ShalokShalom commented 4 years ago

Where can I kiss you? This saved my day. Could someone implement this?

rpgdev commented 4 years ago 
2. `browser.in-content.dark-mode` => true

I'm on firefox 69 and don't seem to need this set to true.

gen3vra commented 4 years ago

Came here and found this after it wouldn't work for me. This fixed it, thank you.

RenatoLopes771 commented 4 years ago

One of the devs should pin this on the homepage as a temporary workaround

sanyer commented 4 years ago

There is a note about this in wiki, but not on repo's README.md.

akitakedits commented 4 years ago

Many thanks ♥

ShalokShalom commented 4 years ago

Why is this not possible to incorporate in the code?

akitakedits commented 4 years ago

It should be, but seems like the project hasn't been updated in forever, can consider it dead.

ShalokShalom commented 4 years ago

I see commits?

overdodactyl commented 4 years ago

This change would have to be implemented in the updater repo. See this issue here:

https://github.com/SrKomodo/shadowfox-updater/issues/53

toxicbubble commented 4 years ago

Can the info that exists on https://github.com/overdodactyl/ShadowFox/wiki/Installation and an additional line for browser.in-content.dark-mode => true be set be added to the "Installation and Updating" section of README.md at least? I spent ages trying to get it to work, and nothing in the installation section of the README.md mentions this. right now it's very unclear why after installation nothing changes.

Thynix commented 3 years ago

@toxicbubble Good idea - I just made a fork and did that. I'll look into getting the updater to automatically do it later this week.