overextended / cfxlua-vscode

https://marketplace.visualstudio.com/items?itemName=overextended.cfxlua-vscode
MIT License
51 stars 23 forks source link

in unpacking not fully supported #13

Open DokaDoka opened 2 years ago

DokaDoka commented 2 years ago

image

thelindat commented 2 years ago

For now I've replaced the whitespace check with space and tab; would require detecting and ignoring comments otherwise.

Proper detection of in syntax likely requires a real Lua parser rather than the basic pattern matching used right now; we need to ensure any instances of in aren't part of a comment, string, function, iterator, etc.

However in syntax has also been known to cause crashes* in the Lua runtime in some rare cases, and per the author of LuaGLM

Should probably avoid using any of the syntax extensions.

* Seemingly when failing to unpack the return value from a function? Can't quite remember. Safe navigation can lead to funny errors too.