overextended / ox_core

Player and vehicle management and persistence for FiveM.
https://overextended.dev/ox_core
GNU Lesser General Public License v3.0
152 stars 124 forks source link

fix(server/player): remove player from OxPlayer when drop during loading #138

Closed CeebDev closed 5 months ago

CeebDev commented 5 months ago

This resolve https://github.com/overextended/ox_core/issues/137

thelindat commented 5 months ago

It would make a lot more sense not to add the player as a member of OxPlayer until they've joined. https://github.com/overextended/ox_core/blob/5a859442e5d7ea1185bb8354974f2307edb904dd/server/player/loading.ts#L35

Should be set under OxPlayer.setAsJoined?

CeebDev commented 5 months ago

Something like this ?