search

overhangio / openedx-scorm-xblock

SCORM XBlock for Open edX
GNU Affero General Public License v3.0
37 stars 48 forks source link

getValue() will never use the JSON handler to get a value #30

Closed bryanlandia closed 1 year ago

bryanlandia commented 1 year ago

https://github.com/overhangio/openedx-scorm-xblock/blob/master/openedxscorm/static/js/src/scormxblock.js#L164-L173

The logical test uses in as in Python, but for JS this needs to be uncachedValues.includes(cmi_element).

bryanlandia commented 1 year ago

Actually this same JS problem affects processSetValueQueueItems as well.