search

overhangio / openedx-scorm-xblock

SCORM XBlock for Open edX
GNU Affero General Public License v3.0
39 stars 50 forks source link

Fix getValue, processSetValueQueueItems uncachedValues check #31

Closed bryanlandia closed 1 year ago

bryanlandia commented 1 year ago

uncachedValues is an Array not Object so element membership needs to use Array.includes()

Fixes #30

bryanlandia commented 1 year ago

Wow, that was a huge bug. Thanks for the PR!

Thanks Régis. Crazy we or nobody else caught it before.

bryanlandia commented 1 year ago

@regisb Let me know if you might be able to cut a new release and push to PyPI.

regisb commented 1 year ago

v15.0.1 was just published to Pypi, along with S3 storage support.

bryanlandia commented 1 year ago

Thanks @regisb . To my mind, v15.0.1 should have been the bugfix, and v16.0.0 as next major version num. should have added the S3 support, but just a suggestion.

regisb commented 1 year ago

v16 indicates compatibility with Palm. The middle version number is for non-backward breaking changes. This xblock follows the same versioning scheme as Tutor: https://docs.tutor.overhang.io/tutor.html#versioning