search

overhangio / openedx-scorm-xblock

SCORM XBlock for Open edX
GNU Affero General Public License v3.0
37 stars 46 forks source link

refactor: remove unused import and rename S3Boto3Storage constructor param #39

Closed ziafazal closed 1 year ago

ziafazal commented 1 year ago

This PR has couple of changes to

  1. Remove unused import
  2. Rename bucket param in S3Boto3Storage constructor to bucket_name since it is removed since 1.10. This change does not break anything in older(1.9) version of django-storages.
ziafazal commented 1 year ago

@regisb could you please review this one?

regisb commented 1 year ago

Thanks for the PR!

awais786 commented 11 months ago

@regisb can you please release the new version ? we are facing issue on production since we have upgraded the django-storages to 1.10.1.