search

overhangio / openedx-scorm-xblock

SCORM XBlock for Open edX
GNU Affero General Public License v3.0
37 stars 46 forks source link

perf: Introduce threading to improve upload speed #46

Closed ziafazal closed 5 months ago

ziafazal commented 10 months ago

This PR introduce threading to concurrently handle file extract and upload, which would improve upload speed of SCORM package and fix #42

ziafazal commented 9 months ago

@regisb could you please take look at this one?

Abdul-Muqadim-Arbisoft commented 6 months ago

I recently uploaded a SCORM package, sized at 6.2 MB, and it took approximately 67 seconds to complete. My network speeds at the time were as follows: download speed at 14.5 Mbps and upload speed at 18.5 Mbps.

regisb commented 6 months ago

@Abdul-Muqadim-Arbisoft thanks for the feedback. Which version of Tutor did you use? Did you also try this PR?

Abdul-Muqadim-Arbisoft commented 6 months ago

@Abdul-Muqadim-Arbisoft thanks for the feedback. Which version of Tutor did you use? Did you also try this PR?

I used tutor quince and the above stats I provided are for this pr

ziafazal commented 6 months ago

@Abdul-Muqadim-Arbisoft this issue was report with tutor 16 or prior version so you have test it with tutor 16 or less.

Abdul-Muqadim2000 commented 6 months ago

@Abdul-Muqadim-Arbisoft this issue was report with tutor 16 or prior version so you have test it with tutor 16 or less.

@ziafazal I will test it today with tutor 16

Abdul-Muqadim-Arbisoft commented 5 months ago

I tested it on tutor 16.1.8, it uploads a SCORM package with s3 storage configured, sized at 6.2 MB, and it takes approximately 7 minutes 30 secs to complete. My network speeds at the time were as follows: download speed at 30 Mbps and upload speed at 19.3 Mbps.

DawoudSheraz commented 5 months ago

Closing this PR as 1) the issue is not present on quince, and 2) the changes/fix do not work entirely as expected.