search

overhangio / openedx-scorm-xblock

SCORM XBlock for Open edX
GNU Affero General Public License v3.0
37 stars 46 forks source link

Grades not set correctly in LMS if lesson_score not updated before completion or pass/fail #56

Closed bryanlandia closed 7 months ago

bryanlandia commented 7 months ago

Some packages may send a cmi.core.lesson_status, cmi.success_status, or cmi.completion_status prior to ever recording a score or the final score. In this case, get_grade could be evaluated with a 0 or otherwise not up-to-date score, and this will be sent to the LMS. The set_value method should update the grade in the LMS even if already passed/failed/completed to avoid missing the updated score.

bryanlandia commented 7 months ago

I'll submit a PR for this

ziafazal commented 7 months ago

@bryanlandia v17.0.1 has fix for this one.