overhangio / tutor-ecommerce

Ecommerce plugin for Tutor
GNU Affero General Public License v3.0
17 stars 50 forks source link

feat: add atlas step to the build - FC-0012 #49

Closed shadinaif closed 8 months ago

shadinaif commented 10 months ago

Adding the pull behind a feature flag until it's fully implemented

IMPORTANT: This PR needs these to be merged first

Background

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

shadinaif commented 10 months ago

Please review @omarithawi, @regisb

shadinaif commented 10 months ago

Done @OmarIthawi . Also, this PR needs https://github.com/openedx/ecommerce/pull/4051 to be merged first. And that's for one reason: atlas is added to requirements in ecommerce PR

brian-smith-tcril commented 9 months ago

@OmarIthawi https://github.com/openedx/ecommerce/pull/4051 has been merged.

@shadinaif it looks like this one needs a rebase

OmarIthawi commented 9 months ago

Thanks @brian-smith-tcril for taking care of the ecommerce PR! Yup, Quince has been tagged. So this one will land post-quince.

We'll rebase, test and let you know when it's ready.

shadinaif commented 9 months ago

rebased, thank you @brian-smith-tcril

OmarIthawi commented 8 months ago

@Faraz32123 This is now ready for merge.

Thanks @shadinaif for the work.

Faraz32123 commented 8 months ago

@shadinaif please add changelog entry.

shadinaif commented 8 months ago

Change log added @Faraz32123 , thank you!