overhangio / tutor-ecommerce

Ecommerce plugin for Tutor
GNU Affero General Public License v3.0
17 stars 50 forks source link

init failed when contact email contains white spaces #51

Closed vunguyen-dmt closed 11 months ago

vunguyen-dmt commented 11 months ago

image

Why my contact email contains white spaces? In Django you can set an email to no-reply@example.com or "My LMS \no-reply@example.com\", the second format will use "My LMS" as the sender name instead of no-reply or no-reply@example.com.

Where is the function? The init file is here https://github.com/overhangio/tutor-ecommerce/blob/master/tutorecommerce/templates/ecommerce/tasks/ecommerce/init It's run with tutor local launch

Solution If this is an issue I think the solution is: Change

  --from-email={{ CONTACT_EMAIL }} \
  --payment-support-email={{ CONTACT_EMAIL }} \

To (with double quotes)

  --from-email="{{ CONTACT_EMAIL }}" \
  --payment-support-email="{{ CONTACT_EMAIL }}" \

ps: I've tried to set CONTACT_EMAIL="My LMS no-reply@example.com" but when I ran tutor config save double quotes were removed.