search

overhangio / tutor-ecommerce

Ecommerce plugin for Tutor
GNU Affero General Public License v3.0
17 stars 50 forks source link

feat: change image CMD to celery v5 compatibility in ecom worker #80

Closed johanseto closed 4 months ago

johanseto commented 4 months ago

Description

This is a proposal in order to allow ecommerce-worker increase celery to v5.4.0

This upgrade of celery is in the following PR: https://github.com/openedx/ecommerce-worker/pull/247

Before

I tried to use the update code related in celery and I found some incompatibilities. For more details you could check the following PR: https://github.com/openedx/ecommerce-worker/pull/247#issuecomment-2083838629 V5.4.0 the celery command doesn't start. image image

image

After

Celery worker in V5.4.0 Seems working 2024-04-29_17-58

2024-04-29_17-57

I also test the args change with celery v4.4.7 but I prefer that this be tested with care. 2024-04-29_17-55

This to think when this PR would be merged: before or after https://github.com/openedx/ecommerce-worker/pull/247

johanseto commented 4 months ago

Closed In favour of : https://github.com/overhangio/tutor-ecommerce/pull/72