Remove bad style rules, so iframe will not be cut-off in MFE

overhangio / tutor-indigo

An elegant, customizable theme for Open edX

GNU Affero General Public License v3.0

74 stars 276 forks source link

Remove bad style rules, so iframe will not be cut-off in MFE #22

Closed insad closed 2 years ago

insad commented 2 years ago

In the MFE, the #content.content-wrapper style rule in _extra.scss pushes the iframe contents down (lots of white space), and besides cuts off the bottom of the iframe, and this without obtaining a "sticky footer" like the comment says. The online Tutor demo (also using Indigo theme) doesn't have this rule, and shows the frontend perfectly, so it looks like this rule should be removed completely.

insad commented 2 years ago

@regis Please can you close this pull request, and consider the other one I just submitted. The other one will fix the problem inside the MFE course content iframe also with a fixed header in the portal pages.