search

overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

When forking Indigo, it appends -indigio multiple times #59

Closed misilot closed 6 months ago

misilot commented 6 months ago

Hello,

When I have both indigo and our nla-theme enabled tutor tries to append indigo twice to the image name.

NLA Theme: https://github.com/newliteraciesalliance/tutor-nla-theme/tree/nla-v17

tutor launch dev results in

[+] Stopping 3/0
 ✔ Container tutor_local-mysql-1        Stopped                                                                                                                                                                  0.0s
 ✔ Container tutor_local-mongodb-1      Stopped                                                                                                                                                                  0.0s
 ✔ Container tutor_local-permissions-1  Stopped                                                                                                                                                                  0.0s
docker compose -f '/Users/user/Library/Application Support/tutor/env/local/docker-compose.yml' -f '/Users/user/Library/Application Support/tutor/env/dev/docker-compose.yml' --project-name tutor_dev up --remove-orphans -d
[+] Running 1/1
 ✘ mfe Error                                                                                                                                                                                                     0.6s
Error response from daemon: manifest for overhangio/openedx-mfe:17.0.0-indigo-indigo not found: manifest unknown: manifest unknown
Error: Command failed with status 18: docker compose -f /Users/user/Library/Application Support/tutor/env/local/docker-compose.yml -f /Users/user/Library/Application Support/tutor/env/dev/docker-compose.yml --project-name tutor_dev up --remove-orphans -d

If I disable one of them, it's able to start up and run.

regisb commented 6 months ago

Well yes, that's because of this function: https://github.com/newliteraciesalliance/tutor-nla-theme/blob/106f0a64f01126995c60d167c8d3fec7ce78651b/nlatheme/plugin.py#L79 If you really want to enable both themes at the same time, then you need to properly handle image naming in your plugin.

misilot commented 6 months ago

Thanks! I didn't realize that it was frowned upon to have both (or that the theme created a custom image name)

On Tue, Feb 13, 2024 at 2:22 AM Régis Behmo @.***> wrote:

Well yes, that's because of this function: https://github.com/newliteraciesalliance/tutor-nla-theme/blob/106f0a64f01126995c60d167c8d3fec7ce78651b/nlatheme/plugin.py#L79 If you really want to enable both themes at the same time, then you need to properly handle image naming in your plugin.

— Reply to this email directly, view it on GitHub https://github.com/overhangio/tutor-indigo/issues/59#issuecomment-1940713755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBHSBYNZDHRMTQI56RC7LYTMPERAVCNFSM6AAAAABDFDYGC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQG4YTGNZVGU . You are receiving this because you authored the thread.Message ID: @.***>