overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

fix: footer date #63

Closed CodeWithEmad closed 6 months ago

CodeWithEmad commented 6 months ago

This will:

Close #62 #64

CodeWithEmad commented 6 months ago

also, Add issue and bugs to project fails because: Error: Input required and not supplied: github-token @regisb @hinakhadim

misilot commented 6 months ago

I don't think this will fix the hard coded date on the MFE apps domain (and others?)

https://apps.sandbox.openedx.edly.io/learner-dashboard/

CodeWithEmad commented 6 months ago

I don't get it. Why not?

misilot commented 6 months ago

At least from what I am seeing is the Apps MFE does not inherit settings from Indigo, though it uses parts of it (like links to the logos) such as the color or footer settings. Maybe it's something broken with my forked theme, but it is something to check.

misilot commented 6 months ago

Yeah, 99% it comes from this https://github.com/edly-io/frontend-component-footer/blob/quince/indigo/src/components/Footer.messages.js#L159-L163

hinakhadim commented 6 months ago

Thanks for the PR. Let me make sure, everything is working for merging. Also, It won't update the MFE footer year because it's hard-coded in MFE footer.

CodeWithEmad commented 6 months ago

You're right, @misilot. It won't fix the hardcoded year in the learner dashboard mfe. I didn't notice the new changes in Quince: RUN npm install '@edx/frontend-component-footer@npm:@edly-io/indigo-frontend-component-footer@^1.0.0' and only checked the https://github.com/openedx/frontend-component-footer, couldn't find any hardcoded thing there and suspected the indigo theme somehow. Is there any documentation about the new changes coming from edly-io? @hinakhadim @regisb

hinakhadim commented 6 months ago

@CodeWithEmad There is no documentation of new changes related to indigo-footer. Let me add this to my to-do list.

hinakhadim commented 6 months ago

@CodeWithEmad Thanks for the PR. Great Work!