overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

If using a custom theme Powered By Logos do no render #65

Closed misilot closed 4 months ago

misilot commented 6 months ago

On the apps MFE pages

Go to course details if you enroll or view an open course, the Runs on Tutor and Powered by Open edX logos are tied to the tutor theme and not a custom one that has been forked, and the images do not render.

Example from: https://apps.test.online.newliteraciesalliance.org/learning/course/course-v1:NLA+IL1015+20_21/home

image
<div class="footer-top"><div class="powered-area"><ul class="logo-list"><li>Powered by</li><li><a href="https://docs.tutor.overhang.io" rel="noreferrer" target="_blank"><img src="https://test.online.newliteraciesalliance.org/static/indigo/images/tutor-logo.png" alt="Runs on Tutor" width="57" class=""></a></li><li><a href="https://open.edx.org" rel="noreferrer" target="_blank"><img src="https://test.online.newliteraciesalliance.org/static/indigo/images/openedx-logo.png" alt="Powered by Open edX" width="79" class=""></a></li></ul></div></div><span class="copyright-site">Copyrights ©2023. All Rights Reserved.</span>
misilot commented 6 months ago

Looks like it is from this MFE?

https://github.com/edly-io/frontend-component-footer/blob/quince/indigo/src/components/Footer.jsx#L58 https://github.com/edly-io/frontend-component-footer/blob/quince/indigo/src/components/Footer.jsx#L67

hinakhadim commented 4 months ago

Thanks to @misilot for resolving, PR Link .