search

overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

Apps MFE does not inherit INDIGO_* settings #66

Closed misilot closed 5 months ago

misilot commented 6 months ago

The apps MFE does not inherit the INDIGO_ settings such as 

INDIGO_FOOTER_LEGAL_LINKS
INDIGO_FOOTER_NAV_LINKS
INDIGO_PRIMARY_COLOR
DawoudSheraz commented 6 months ago

@misilot Hello. The current description does not have enough context for the underlying issue. Can you add more details about the issue, its impact, etc.? Thanks

misilot commented 6 months ago

Sure,

So INDIGO_PRIMARY_COLOR used to apply to the primary color in the _variable.scss file, but that was removed in https://github.com/overhangio/tutor-indigo/pull/54

However, this variable does not pass to the MFE as part of the theming for the full site.

Secondary, both INDIGO_FOOTER_LEGAL_LINKS and INDIGO_FOOTER_NAV_LINKS do not trickle down to the MFE (apps.* subsites), so the footer is not consistent on the different pages as a learner goes through the site.

hinakhadim commented 6 months ago

Hi @misilot , Currently the MFEs don't get the INDIGO_ settings. The Links settings don't passed to MFEs because these are the array and the primary color settings don't passed to MFEs because MFEs are styled using brand-openedx npm package. Therefore, It doesn't make sense to pass theme_color variable to MFEs when it is of no use. Furthermore, the community has added ADR for making footer-links consistent on overall platform (including LMS and MFEs). But development on it is paused now, as we are exploring UI Plugin Approach for MFEs. This is where community is looking at. If there's anything I missed, feel free to share.