Closed kdmccormick closed 4 months ago
Thanks for creating the issue. It has been resolved in @edly-io/indigo-brand-openedx@1.4.1
as the styling of MFEs and its components depend on this package.
Why it has not been resolved in tutor-indigo
?
Due to incompatibility issues in MFEs (master branch) and header component versions, we have decided to remove Indigo header component and would use the bydefault openedx header component. Since the brand package styles are applied on classes which are identical in both indigo header and openedx header, that's disturbed the styling of openedx header when removing the indigo header.
Workaround: Add a custom class to indigo header and did styling in brand on the basis of that class for header component. So, The styling of indigo header won't affect the openedx header styles now.
Screenshots
Seems like the header text either needs to be broken into two lines, or it needs some padding tweaks that it looks better on one line.
Without tutor-indigo installed:
With tutor-indigo installed
Reproduction
Simply install indigo, enable it, rebuild the MFE image, start Tutor, and navigate to a course.
This does not seem to be impacting Quince. I believe it only impacts Nightly. I tested both
tutor local
andtutor dev
. I did not try mounting frontend-app-learning.System info:
Both indigo and mfe are installed from a local git-clone at the tip of their
nightly
branches.