search

overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

Faint unexpected rectangle in the course about page #81

Closed mariajgrimaldi closed 2 months ago

mariajgrimaldi commented 3 months ago

Expected behavior

Not 100% sure - this might actually be a design choice rather than a bug.

Actual behavior

There's a light-colored rounded rectangle behind and offset from the course image. I'm not 100% sure that's intentional - not sure whether it's supposed to be there or directly behind the image.

Screenshot 2024-05-17 at 9 47 22 AM

Steps to reproduce

Just visit any About page.

Additional information

In ones without an image you get a blank square in front of the rectangle.

Screenshot 2024-05-17 at 9 48 06 AM

Original issue: https://github.com/openedx/wg-build-test-release/issues/345

I'm opening this issue to confirm whether this is a design choice or a bug. I'm unfamiliar with the indigo theme, so I can't say for sure.

mariajgrimaldi commented 3 months ago

label: release testing

mariajgrimaldi commented 3 months ago

Well, that didn't work 😅.

DawoudSheraz commented 3 months ago

@hinakhadim FYI

DawoudSheraz commented 3 months ago

Well, that didn't work 😅.

I think this is because the repo is in overhangio organization and not Open edX.

hinakhadim commented 3 months ago

Hi @mariajgrimaldi ,

This is a design choice. The rectangle position is also correct and it won't be just behind the image.

However, the second screenshot is a bug. There should be the thumbnail/fallback course image in case of no course image.

mariajgrimaldi commented 3 months ago

@hinakhadim: thanks for clarifying!

hinakhadim commented 3 months ago

This PR will resolve the second screenshot (bug).