overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

Sidebar navigation, discussions, or notifications take over half the width of the page when Indigo theme is used #83

Closed GlugovGrGlib closed 2 months ago

GlugovGrGlib commented 2 months ago

Description

This issue was reported as part of Redwood release testing. Because the indigo theme is enabled by default since Quince release for all Tutor deployments, this issue is considered a major problem for Open edX.

The original issue found during release testing - https://github.com/openedx/frontend-app-learning/issues/1401

Please find more info about a possible technical solution in the comment: https://github.com/openedx/frontend-app-learning/issues/1401#issuecomment-2148622086

Steps to Reproduce

  1. Login to an instance using the Indigo theme as an admin user to ensure the courseware.enable_navigation_sidebar waffle flag is enabled
  2. Navigate to an in-course experience page
  3. With the sidebar navigation expanded, view the page

Expected Behavior

  1. The sidebar navigation when expanded takes up much less than half of the page horizontally (see attached image from an in-course experience page using the Open edX theme)
  2. There is a reasonable amount of blank space on either side of the course content/sidebar content

Default Open edX theme:

image

Actual Behavior

  1. The sidebar navigation when expanded takes up half of the page horizontally (see attached image from an in-course experience page using the Indigo theme)
  2. There is a lot of extra blank space on either side of the course content/sidebar content

Full HD:

image

Wide screen:

image
GlugovGrGlib commented 2 months ago

@DawoudSheraz FYI about this product request

DawoudSheraz commented 2 months ago

Thanks @GlugovGrGlib FYI @hinakhadim

hinakhadim commented 2 months ago

Hi @GlugovGrGlib , Thanks for taking time and identifying this. This PR will resolve this issue with tutor-indigo version 17.4.0.