search

overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
73 stars 275 forks source link

Let the platform decide where to take the user #87

Closed CodeWithEmad closed 2 months ago

CodeWithEmad commented 2 months ago

Hi. I don't think that this is not a big issue but we should let the platform decide where to take the user since we can change the login. I believe checking for should_redirect_to_authn_mfe is happening in the edx-platform and there's no need for that

https://github.com/overhangio/tutor-indigo/blob/1dc3c5c10919a4b3581cbb9307fbba2e19366422/tutorindigo/templates/indigo/lms/templates/header/navbar-not-authenticated.html#L52-L70

for example, if you set THIRD_PARTY_AUTH_HINT to your tpa slug, /login will take you to that page, instead of login in authn MFE.