search

overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
78 stars 303 forks source link

Fix for preview-menu being hidden #9

Closed Sigurd-Borge closed 4 years ago

Sigurd-Borge commented 4 years ago

Closes #8

regisb commented 4 years ago

Thanks for this PR @Doppern! I would like to keep the header.global-header position fixed, such that it stays on top of the screen when the user scrolls down (on large screens only). Do you think you could achieve that?

Sigurd-Borge commented 4 years ago

Maybe a bit clunky - CSS is hardly my specialty, but it seems to work by adding the same properties to the preview-menu.

regisb commented 4 years ago

I found a simpler fix ;) https://github.com/overhangio/indigo/commit/62cbabcd625bb1b81f009b0052dc81f483be3218

Sigurd-Borge commented 4 years ago

That looks more elegant indeed - unfortunately the menu only shows on the "Front page" of a course, and not on all pages, the margin-top: 75px; doesn't get added on all pages for some reason (I assume the way the SASS is processed?) so this is not a complete fix.

regisb commented 4 years ago

Indeed @Doppern, I can verify what you are describing. This issue is visible here: https://demo.openedx.overhang.io/courses/course-v1:edX+DemoX+Demo_Course/courseware/interactive_demonstrations/19a30717eff543078a5d94ae9d6c18a5/?activate_block_id=block-v1%3AedX%2BDemoX%2BDemo_Course%2Btype%40sequential%2Bblock%4019a30717eff543078a5d94ae9d6c18a5 My understanding is that the CSS rule is being overridden by a higher priority rule which states margin: 0. This can be resolved by making the css rule even more precise -- e.g: .wrapper-preview-menu --> nav.wrapper-preview-menu. I'll push another fix.