overhangio / tutor-indigo

An elegant, customizable theme for Open edX
GNU Affero General Public License v3.0
78 stars 303 forks source link

fix: problem displaying /account/ page after upgraded to redwood #96

Closed hinakhadim closed 2 months ago

hinakhadim commented 2 months ago

Issue: With Tutor v18 and Tutor Indigo v18.1.0, users are unable to view the accounts page. Tutor Indigo v18.1.0 has installation of custom indigo header and footer in learning, dashboard, profile, discussion and account MFE. All MFEs are compatible with indigo header and footer except accounts MFE. The reason is:

In redwood: Most of the MFEs using ----> footer v14

Account MFE -----> footer v13

Our indigo footer is created from footer v14 and we are installing it in all MFEs (account MFE has footer v13). More details can be found on this issue

Solves https://github.com/overhangio/tutor/issues/1111

hinakhadim commented 2 months ago

This PR does 2 things:

  1. Add indigo-footer to MFEs using PluginSlot. Before the footer was installed using "alias".
  2. Update the indigo-header version to ~3.0.0 from ^3.0.0
hinakhadim commented 2 months ago

@regisb We don't require to merge this PR. I have created a PR in tutor-mfe https://github.com/overhangio/tutor-mfe/pull/221 and it has the patch for fixing this issue. The de-duplication of code will be done in the next PR (toggle button theme).