search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

The password reset link included in emails is invalid #105

Closed vunguyen-dmt closed 1 year ago

vunguyen-dmt commented 1 year ago

The setup process for AUTHN mfe should set AUTHN_MICROFRONTEND_DOMAIN = {{ MFE_HOST }}/{{ MYMFE_MFE_APP["name"] }} otherwise reset password link will be: https://none/password_reset_confirm/....

regisb commented 1 year ago

Hi @vunguyen-dmt! To better understand your issue we need to be able to reproduce it. Can you please describe the steps that we should follow to observe the issue in practice? Screenshots would be nice, too.

vunguyen-dmt commented 1 year ago

Steps to reproduce:

  1. Install tutor 15.1.0.
  2. Install tutor-mfe latest.
  3. Set up smpt email.
  4. Register/create an account with a real email and then do email activation.
  5. Go to forgot password page (Authn MFE), for example: https://apps.demo.openedx.overhang.io/authn/reset . Fill in email, click submit and wait for the reset password email.
  6. Click on the reset password link, it will go to https://none/password_reset_confirm/{some_token}/?track=pwreset

To fix the issue I have to set: AUTHN_MICROFRONTEND_DOMAIN = {{ MFE_HOST }}/{{ MYMFE_MFE_APP["name"] }}

I don't know if people remember to set the AUTHN_MICROFRONTEND_DOMAIN, I think it will be better if it's set during the installing process of tutor-mfe. I think it could be done by modifying this file: https://github.com/overhangio/tutor-mfe/blob/master/tutormfe/patches/openedx-lms-common-settings

arbrandes commented 1 year ago

Huh. This went totally under the radar. Indeed, we need to set a variable for it, but it's not documented anywhere.