search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

Wrong reset password link in authn mfe #112

Closed vunguyen-dmt closed 1 year ago

vunguyen-dmt commented 1 year ago

Reproduce: Goto: https://apps.demo.openedx.overhang.io/authn/login Try logging in with: username: admin, password: 123456 a few times. The site will show a message including: "To be on the safe side, you can reset your password before trying again." the link will go to /reset instead of /authn/reset/ __ There are a few messages like that and reset password links are all the same. This could relate to this file: https://github.com/openedx/frontend-app-authn/blob/master/src/login/LoginFailure.jsx

regisb commented 1 year ago

I can confirm the reported issue. Here is a screenshot. Notice the reset link in the bottom left corner:

Screenshot from 2023-02-21 17-11-43

That particular line of code looks fishy: https://github.com/openedx/frontend-app-authn/blob/open-release/olive.2/src/login/LoginFailure.jsx#L32

johnvente commented 1 year ago

Hello @regisb I'm a new frontend at eduNext, would you mind assigning me this issue please?

arbrandes commented 1 year ago

@johnvente, thanks for volunteering! :)

johnvente commented 1 year ago

Hi guys, I wasn't able to reproduce the error. was this issue fixed already or does it continue happening?

Here is a screenshot:

Image

regisb commented 1 year ago

Looks like the issue was fixed by replacing "/reset" by "reset". Compare: https://github.com/openedx/frontend-app-authn/blob/open-release/olive.2/src/login/LoginFailure.jsx#L32 https://github.com/openedx/frontend-app-authn/blob/open-release/palm.1/src/login/LoginFailure.jsx#L34

Congrats on resolving this issue @johnvente ;) @vunguyen-dmt if you agree, can you please close this?

vunguyen-dmt commented 1 year ago

Tested and it was fixed!