fix: Add account url in dynamic config

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.

GNU Affero General Public License v3.0

22 stars 95 forks source link

fix: Add account url in dynamic config #121

Closed ghassanmas closed 1 year ago

ghassanmas commented 1 year ago

frontend-component-header since version v.3.5 requires the the settings of ACCOUNT_SETTINGS_URL to exists as it uses it point to the account MFE.

openedx/frontend-component-header/pull/210 PR that add the setting the componenet
openedx/wg-build-test-release/issues/268 which this fixes

arbrandes commented 1 year ago

@ghassanmas, is this still necessary? Can you rebase the PR, if so? Thanks!

ghassanmas commented 1 year ago

@arbrandes I rebased, but I am still not sure if PR is needed, if merging it with palm would be a headche, so then may be better to commit the changes directly to palm. So I defer to you to do what is best

ghassanmas commented 1 year ago

I think it still needed, looking at palm branch there still no defintion of ACCOUNT_SETTINGS_URL which is used by the new frontend-comp-header, as expalined above.