search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

fix: pngquant error during build on linux/arm64 #123

Closed regisb closed 1 year ago

regisb commented 1 year ago

Building the mfe Docker image on arm64 triggers the following error in the 'account-prod' stage:

Cannot find module 'imagemin-pngquant'

This was due to a missing system package.

I find it strange that no one reported this issue before, when there are plenty of users running macOS with arm64. I discovered this issue while setting up a multi-arch build CI environment.

regisb commented 1 year ago

@arbrandes I'm taking the liberty to merge this and make a new release to fix the arm64 build.

bradenmacdonald commented 1 year ago

I find it strange that no one reported this issue before

I think that the mfe images were usually built as AMD64, probably because whatever base image they were using at the time was amd64 only, though it could be some other reason. So at least personally I never tried building them on ARM. But as mentioned on Slack, it does seem to be working now :)