search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

Fix: MFE_HOST check with the new CONFIG_LOADED action #150

Closed CodeWithEmad closed 1 year ago

CodeWithEmad commented 1 year ago

As a part of https://github.com/overhangio/tutor/issues/557, we should warn the users if they're not following the apps.LMS_HOST pattern for the MFE_HOST. This will introduce a new check to see if the MFE_HOST is a subdomain of LMS_HOST or not using the new CONFIG_LOADED action .

CodeWithEmad commented 1 year ago

LGTM! Can you please just add a changelog entry with scriv create?

Done.