search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

fix: remove trailing slash from PUBLIC_PATH env var #154

Closed ormsbee closed 1 year ago

ormsbee commented 1 year ago

We previously generated the PUBLIC_PATH base for each MFE with a trailing slash, e.g. "/authn/". But the actual links that point to these from the LMS and Studio don't have a trailing slash in them, e.g. "/authn". This commit removes the trailing slash to be consistent.

ormsbee commented 1 year ago

FYI @brian-smith-tcril, @arbrandes

regisb commented 1 year ago

Hi Dave! Thanks for the PR. Does this change fix a particular issue, or is it just a cosmetic change?

brian-smith-tcril commented 1 year ago

@regisb if this change gets in it should remove the need to add extra trailing slash handling logic in frontend-platform (which is now needed due to changes in React Router v6). The discussion on https://github.com/openedx/frontend-platform/pull/574 can provide more context.

regisb commented 1 year ago

I have no idea what's going on and I should never have asked :sweat_smile: passing it on to you @arbrandes! I'd just like to ask that you create a changelog entry with scriv create and to explain in that entry why the change was made (as opposed to what was made). For instance "make it easier and consistent for frontend-patform to parse the PUBLIC_PATH" could be a perfectly reasonable changelog description.