search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

Feat: Testing and Linting #155

Closed CodeWithEmad closed 1 year ago

CodeWithEmad commented 1 year ago

This will add a Makefile, clean the code with isort and black, and fix typing issues. Closes https://github.com/overhangio/tutor-mfe/issues/151

CodeWithEmad commented 1 year ago

@regisb Should I modify the gh_refs_path function so that "refs": "GITHUB_API" + gh_refs_path() is replaced by "refs": gh_refs_path("openedx/frontend-app-account")? Also, don't we wanna have make isort and make format run in the test.yml?

regisb commented 1 year ago

Should I modify the gh_refs_path function so that "refs": "GITHUB_API" + gh_refs_path() is replaced by "refs": gh_refs_path("openedx/frontend-app-account")?

Yes, good idea!

Also, don't we wanna have make isort and make format run in the test.yml?

I think that's convenient, yes.

CodeWithEmad commented 1 year ago

I think that's a great step forward, and the PR looks good as it is.

I'm happy to hear that!

black and isort steps added and gh_refs_path reformatted.

CodeWithEmad commented 1 year ago

I have resolved the conflicts that were caused by merging my last pull request.

Also I had another thing in mind. Shouldn't we update documents to inform contributors about running make ... commands before creating new PRs?

CodeWithEmad commented 1 year ago

Just a friendly reminder @kdmccormick @arbrandes