search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

[nightly] feat: add support for the Learner Dashboard MFE #164

Closed arbrandes closed 1 year ago

arbrandes commented 1 year ago

Adds support for the Learner Dashboard MFE.

The MFE itself still has a few pending fixes to make it release-ready (see the list of PRs in this issue), but we might as well merge it to nightly as we fix it up.

regisb commented 11 months ago

@arbrandes I just discovered that the learner dashboard port clashes with the ecommerce MFE. Both use 1996: https://github.com/openedx/frontend-app-ecommerce https://github.com/openedx/frontend-app-learner-dashboard

As a consequence, we can no longer run the ecommerce plugin in nightly. We should change the port of one of these two MFEs in Tutor. Adolfo: which solution do you suggest? How does the devstack bypass this issue?

arbrandes commented 11 months ago

@regisb, the devstack doesn't ship frontend-app-ecommerce out of the box. Only frontend-app-payment. And that uses port 1998.

In any case, I don't have a strong opinion on which one should be changed, architecturally speaking. I will say, though, that whichever one is changed, it's also worth submitting the change upstream (to the MFE repo, devstack, etc). Let me know if you think it's the Dashboard that should change.