search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

feat: enable `atlas pull` for all MFEs | FC-0012 #184

Closed OmarIthawi closed 8 months ago

OmarIthawi commented 9 months ago

Changes

TODOs

Blocking PRs

This pull request will fail unless the following PRs are merged:

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

OmarIthawi commented 9 months ago

@regisb @arbrandes the change log and docs are ready.

We're still pending the rest of MFEs pulll requests to get merged but please let me know if there's anything to change in the docs.

OmarIthawi commented 9 months ago

@regisb @DawoudSheraz This is finally ready for review. Please let me know if you have any questions or concerns.

OmarIthawi commented 8 months ago

@arbrandes I was going to ping you that notes has been addressed, but you merged it already!

Thanks! If you're using a great GitHub AI bot please let me know, otherwise it's an amazing turnaround 😄

arbrandes commented 8 months ago

@OmarIthawi, lol, no, I'm just doing a Github notification run now, ordered by newest first. ;)

OmarIthawi commented 8 months ago

It's still very fast, but it's a relief that I'm not missing out 😅

regisb commented 8 months ago

@OmarIthawi turns out that this is breaking the build in CI:

linux/amd64 profile-common 5/5] RUN make OPENEDX_ATLAS_PULL=true ATLAS_OPTIONS="--repository=openedx/openedx-translations --revision=main " pull_translations:
0.187 mkdir src/i18n/messages
0.194 cd src/i18n/messages \
0.194       && atlas pull --repository=openedx/openedx-translations --revision=main  \
0.194                translations/frontend-platform/src/i18n/messages:frontend-platform \
0.194                translations/paragon/src/i18n/messages:paragon \
0.194                translations/frontend-component-header/src/i18n/messages:frontend-component-header \
0.194                translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
0.194                translations/frontend-app-profile/src/i18n/messages:frontend-app-profile
0.195 /bin/sh: 2: atlas: not found
0.196 make: *** [Makefile:62: pull_translations] Error 127
------
Dockerfile:444
--------------------
 442 |     COPY --from=profile-src / /openedx/app
 443 |     
 444 | >>> RUN make OPENEDX_ATLAS_PULL=true ATLAS_OPTIONS="--repository=openedx/openedx-translations --revision=main " pull_translations
 445 |     
 446 |     EXPOSE 1995
--------------------
ERROR: failed to solve: process "/bin/sh -c make OPENEDX_ATLAS_PULL=true ATLAS_OPTIONS=\"--repository=openedx/openedx-translations --revision=main \" pull_translations" did not complete successfully: exit code: 2
Error: Command failed with status 1: docker buildx build --tag=docker.io/overhangio/openedx-mfe:17.0.0-nightly --output=type=image --platform=linux/amd64,linux/arm64 --cache-from=type=registry,ref=docker.io/overhangio/openedx-mfe:17.0.0-nightly-cache /ci/.local/share/tutor-nightly/env/plugins/mfe/build/mfe

Can you please have a look?

OmarIthawi commented 8 months ago

Taking a look now @regisb. Could it be that the CI has stale cache?

OmarIthawi commented 8 months ago

Some process have removed the openedx-atlas from the frontend app profile:

I think it's a matter of a bad conflict resolution. This should never happen, but that's what CI is for.

The fault isn't in the plugin, so I'll fix the other MFE.

OmarIthawi commented 8 months ago

Fix is on the way: https://github.com/openedx/frontend-app-profile/pull/976

arbrandes commented 8 months ago

I just merged the fix. Thanks, @OmarIthawi!

OmarIthawi commented 8 months ago

Thanks @arbrandes!! Please let me know if all is good now.

cc: @regisb

regisb commented 8 months ago

Thanks for the super quick turnaround guys :)