search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

fix: add account mfe patch to show account page #221

Closed hinakhadim closed 2 months ago

hinakhadim commented 3 months ago

Issue: With Tutor v18 and Tutor Indigo v18.1.0, users are unable to view the accounts page. Tutor Indigo v18.1.0 has installation of custom indigo header and footer in learning, dashboard, profile, discussion and account MFE. All MFEs are compatible with indigo header and footer except accounts MFE. The reason is:

In redwood: Most of the MFEs using ----> footer v14

footer is installed via @openedx/frontend-slot-footer package footer is imported like import FooterSlot from '@openedx/frontend-slot-footer'; Account MFE -----> footer v13

footer is installed via @edx/frontend-component-footer footer is imported like import { FooterSlot } from '@edx/frontend-component-footer'; Our indigo footer is created from footer v14 and we are installing it in all MFEs (account MFE has footer v13). More details can be found on https://github.com/openedx/frontend-app-account/issues/1071

This PR adds the patch in account-mfe which fixes the above issue

Solves https://github.com/overhangio/tutor/issues/1111

hinakhadim commented 2 months ago

Closing this PR due to merge conflicts caused by the included patch, which is preventing the patch from being applied successfully and resulting in errors.

Applying: fix: import `FooterSlot` from `frontend-slot-footer` package (#1048)
error: patch failed: package-lock.json:10
error: package-lock.json: patch does not apply
error: patch failed: package.json:28
error: package.json: patch does not apply
error: patch failed: src/index.jsx:11
error: src/index.jsx: patch does not apply
Patch failed at 0001 fix: import `FooterSlot` from `frontend-slot-footer` package (#1048)