search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

fix: enable meilisearch in MFE config #231

Closed pomegranited closed 2 weeks ago

pomegranited commented 3 weeks ago

Depends on https://github.com/overhangio/tutor/pull/1141

Part of: https://github.com/openedx/modular-learning/issues/236

Faraz32123 commented 3 weeks ago

why not adding this setting to openedx-lms-common-settings instead of adding in both dev and prod patches?

regisb commented 3 weeks ago

It's true we could probably move the shared configurations to "openedx-lms-common-settings". I'd say it's slightly beyond the scope of this PR, and we risk running into rebase conflicts if we make other changes in the master branch until Sumac is released. But I'll agree with whatever ya'll decide.

pomegranited commented 3 weeks ago

@Faraz32123 Let me know what you'd like me to do? I'm just a user of this repo, not an expert like y'all :)

Faraz32123 commented 2 weeks ago

@Faraz32123 Let me know what you'd like me to do? I'm just a user of this repo, not an expert like y'all :)

@pomegranited all good from your side, Thanks. I think, we can merge this PR. We'll refactor the patches in a separate PR.

DawoudSheraz commented 2 weeks ago

I am going to merge this PR, we can add the changelog in a follow-up PR. Since Sumac sandbox is going to be re-created on Monday morning, it is essential to have this change in place as tutor core PR for meilisearch has been merged.