search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

fix: building mfe image on arm64 #42

Closed regisb closed 2 years ago

regisb commented 2 years ago

Additional requirements are required, and we cannot download the pact binary on arm64: https://github.com/pact-foundation/pact-js-core/issues/264

Close #31.

bradenmacdonald commented 2 years ago

@regisb

I ran tutor images build mfe and it worked, and I can confirm the resulting image has the arm64 architecture. 👍🏻

jigsawlabs-student commented 2 years ago

@regisb Unfortunately I continue to run into an error on this.

tutor images build mfe

#49 73.51 > @pact-foundation/pact-node@10.13.8 postinstall /openedx/app/node_modules/@pact-foundation/pact-node
#49 73.51 > node postinstall.js
#49 73.51
#49 73.72 /openedx/app/node_modules/@pact-foundation/pact-node/standalone/install.js:41
#49 73.72     throw new Error(chalk_1.default.red("Error while installing binary: " + msg));
#49 73.72     ^
#49 73.72
#49 73.72 Error: Error while installing binary: Cannot find binary for platform 'linux' with architecture 'arm64'.
#49 73.72     at throwError (/openedx/app/node_modules/@pact-foundation/pact-node/standalone/install.js:41:11)
#49 73.72     at getBinaryEntry (/openedx/app/node_modules/@pact-foundation/pact-node/standalone/install.js:289:11)
regisb commented 2 years ago

Why is it working for @bradenmacdonald but not for @jigsawlabs-student? Are you quite sure that you checked out the "regisb/fix-arm-build" branch on your local Tutor repository? Did you also run tutor config save && tutor images build mfe?

jigsawlabs-student commented 2 years ago

Let me try again with checking out the fix arm branch..thanks for clarifying that.

On Thu, Mar 31, 2022 at 9:01 AM Régis Behmo @.***> wrote:

Why is it working for @bradenmacdonald https://github.com/bradenmacdonald but not for @jigsawlabs-student https://github.com/jigsawlabs-student? Are you quite sure that you checked out the "regisb/fix-arm-build" branch on your local Tutor repository? Did you also run tutor config save && tutor images build mfe?

— Reply to this email directly, view it on GitHub https://github.com/overhangio/tutor-mfe/pull/42#issuecomment-1084547662, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKFJMH5S5CIOAC3YUBV3FTVCWOZTANCNFSM5QVTON2Q . You are receiving this because you were mentioned.Message ID: @.***>

regisb commented 2 years ago

OK without further information I'll assume that this fixes image building on arm64.